Re-add the ghost import to da __init__ #3861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for libraries that implicitly assumed `da.ghost` namespace was automatically imported.
|
Failure is unrelated. @shoyer, can you confirm this fixes your issue? |
|
We just coincidentally merged the PR updating xarray to work around this,
so I'm not sure...
…On Wed, Aug 8, 2018 at 6:49 AM Jim Crist ***@***.***> wrote:
Failure is unrelated. @shoyer <https://github.com/shoyer>, can you
confirm this fixes your issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3861 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABKS1tcd8-7cUQQaBj4yNtYs-eGC6VG1ks5uOux9gaJpZM4VzII2>
.
|
|
But it sure looks like this would have done it
…On Wed, Aug 8, 2018 at 8:23 AM Stephan Hoyer ***@***.***> wrote:
We just coincidentally merged the PR updating xarray to work around this,
so I'm not sure...
On Wed, Aug 8, 2018 at 6:49 AM Jim Crist ***@***.***> wrote:
> Failure is unrelated. @shoyer <https://github.com/shoyer>, can you
> confirm this fixes your issue?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#3861 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABKS1tcd8-7cUQQaBj4yNtYs-eGC6VG1ks5uOux9gaJpZM4VzII2>
> .
>
|
|
Well this should be done anyway as part of the deprecation process. Merging. Thanks for catching this @shoyer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for libraries that implicitly assumed
da.ghostnamespace wasautomatically imported.
See #3830.