Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain intermediate storage #4025

Merged
merged 10 commits into from May 1, 2019

Conversation

Projects
None yet
3 participants
@jakirkham
Copy link
Member

commented Sep 29, 2018

Provide some prose to explain the use case of storing intermediate values using return_stored as well as some examples of these common use cases.

DOC: Explain intermediate storage [ci skip]
Provide some prose to explain the use case of storing intermediate
values using `return_stored` as well as some examples of these common
use cases.
Show resolved Hide resolved docs/source/array-creation.rst Outdated
Show resolved Hide resolved docs/source/array-creation.rst Outdated
Show resolved Hide resolved docs/source/array-creation.rst Outdated
@mrocklin

This comment has been minimized.

Copy link
Member

commented Oct 1, 2018

Thanks for writing this up. I've added a few comments with some concerns, but I'm confident that we can come to something that will be pretty useful for readers.

@martindurant

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@jakirkham , sounds like this didn't need too much effort to push it in, were you thinking to work on it yet?

@jakirkham

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

Alright I've gone through this and more or less rewritten the text. IMHO it is much better, but please take a look and let me know if it captures what you were after. Have also moved the section.

@mrocklin

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

IMHO it is much better

:) Not sure that you can say that

@mrocklin
Copy link
Member

left a comment

Some nitpicky comments. In general this looks great though!

Show resolved Hide resolved docs/source/array-creation.rst Outdated
Show resolved Hide resolved docs/source/array-creation.rst Outdated
Show resolved Hide resolved docs/source/array-creation.rst Outdated

jakirkham and others added some commits May 1, 2019

Update docs/source/array-creation.rst
Co-Authored-By: jakirkham <jakirkham@gmail.com>

@mrocklin mrocklin merged commit 0199be4 into dask:master May 1, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@mrocklin

This comment has been minimized.

Copy link
Member

commented May 1, 2019

Thanks @jakirkham . This looks good to me. Merging in.

@jakirkham

This comment has been minimized.

Copy link
Member Author

commented May 1, 2019

Thanks for the review Matt! Hopefully this helps some people 🙂

@jakirkham jakirkham deleted the jakirkham:doc_return_stored branch May 1, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Thomas-Z added a commit to Thomas-Z/dask that referenced this pull request May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.