Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain intermediate storage #4025

Merged
merged 10 commits into from May 1, 2019
Merged

Explain intermediate storage #4025

merged 10 commits into from May 1, 2019

Conversation

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Sep 29, 2018

Provide some prose to explain the use case of storing intermediate values using return_stored as well as some examples of these common use cases.

Provide some prose to explain the use case of storing intermediate
values using `return_stored` as well as some examples of these common
use cases.
docs/source/array-creation.rst Outdated Show resolved Hide resolved
docs/source/array-creation.rst Outdated Show resolved Hide resolved
docs/source/array-creation.rst Outdated Show resolved Hide resolved
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Oct 1, 2018

Thanks for writing this up. I've added a few comments with some concerns, but I'm confident that we can come to something that will be pretty useful for readers.

@martindurant
Copy link
Member

@martindurant martindurant commented Apr 30, 2019

@jakirkham , sounds like this didn't need too much effort to push it in, were you thinking to work on it yet?

@jakirkham
Copy link
Member Author

@jakirkham jakirkham commented Apr 30, 2019

Alright I've gone through this and more or less rewritten the text. IMHO it is much better, but please take a look and let me know if it captures what you were after. Have also moved the section.

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Apr 30, 2019

IMHO it is much better

:) Not sure that you can say that

Copy link
Member

@mrocklin mrocklin left a comment

Some nitpicky comments. In general this looks great though!

docs/source/array-creation.rst Outdated Show resolved Hide resolved
docs/source/array-creation.rst Outdated Show resolved Hide resolved
docs/source/array-creation.rst Outdated Show resolved Hide resolved
@mrocklin mrocklin merged commit 0199be4 into dask:master May 1, 2019
0 of 2 checks passed
@mrocklin
Copy link
Member

@mrocklin mrocklin commented May 1, 2019

Thanks @jakirkham . This looks good to me. Merging in.

@jakirkham
Copy link
Member Author

@jakirkham jakirkham commented May 1, 2019

Thanks for the review Matt! Hopefully this helps some people 🙂

@jakirkham jakirkham deleted the doc_return_stored branch May 1, 2019
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants