New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4278 #4280

Merged
merged 3 commits into from Dec 9, 2018

Conversation

Projects
None yet
2 participants
@515hikaru
Copy link
Contributor

515hikaru commented Dec 8, 2018

I made it possible to run a test with pytest==4.0.1(this version is latest now.)

related issue: #4278

  • Tests added / passed
  • Passes flake8 dask

@515hikaru 515hikaru changed the title fix #4278 WIPfix #4278 Dec 8, 2018

@515hikaru 515hikaru changed the title WIPfix #4278 WIP: fix #4278 Dec 8, 2018

@mrocklin

This comment has been minimized.

Copy link
Member

mrocklin commented Dec 8, 2018

Thank you for starting this @515hikaru . Are you interested in doing this same work for the other tests?

You can get a list of all failing tests with by looking at the "Warnings Summary" in one of the Travis CI logs. You could also change the pytest version here:

https://github.com/dask/dask/blob/master/continuous_integration/travis/install.sh#L54

@515hikaru

This comment has been minimized.

Copy link
Contributor

515hikaru commented Dec 9, 2018

@mrocklin: Thank you for your information. I want to fix other tests.

I will change pytest version when all tests fixed.

fix #4278
* dask/bytes
* dask/dataframe/io/tests

and change pytest version

@515hikaru 515hikaru force-pushed the 515hikaru:master branch from 06e627b to 3237cc1 Dec 9, 2018

@515hikaru 515hikaru changed the title WIP: fix #4278 fix #4278 Dec 9, 2018

@515hikaru

This comment has been minimized.

Copy link
Contributor

515hikaru commented Dec 9, 2018

I fixed all tests, and changed pytest version in travis job.

Although travis 3rd job fails, I do not know how to fix it.It seems this issue is another one, is not it?

@mrocklin

This comment has been minimized.

Copy link
Member

mrocklin commented Dec 9, 2018

Yes, it's unrelated and being handled in #4276 . Merging this now. Thank you @515hikaru !

If you want to continue with this work the other Dask repositories like dask/distributed and dask/dask-ml probably also have this same problem.

I also notice that this is your first code contribution to this repository. Welcome!

@mrocklin mrocklin merged commit 8bd87a4 into dask:master Dec 9, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@mrocklin mrocklin referenced this pull request Jan 23, 2019

Open

Support pytest 4 #2476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment