Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add section of `Using Other S3-Compatible Services` for remote-data-services #4405

Merged
merged 4 commits into from Feb 14, 2019

Conversation

Projects
None yet
3 participants
@aploium
Copy link
Contributor

commented Jan 20, 2019

No description provided.

@mrocklin

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

@martindurant
Copy link
Member

left a comment

I am OK with adding this explanation to the docs here. Note that a PR to S3FS may be in order to clear up some of the similar config confusion that may exist there.

Show resolved Hide resolved docs/source/remote-data-services.rst Outdated
Show resolved Hide resolved docs/source/remote-data-services.rst
@martindurant

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

OK, thank you.

@martindurant

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

Assuming tests would pass following merger of #4413 ?

@aploium

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

Assuming tests would pass following merger of #4413 ?

I beleve so, because there is not any code change in this PR, but just doc

@martindurant

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

That PR was merged, can you please pull and merge from master @aploium ?

@aploium

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

i'll do it tomorrow, because it' very late here ( UTC+8) :)
thank you

@aploium

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

It still fails (in different places), but I don't why.
TypeError: can't pickle _thread.RLock objects @martindurant

#4418 also failed in same place

@martindurant

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

@aploium , the issue you were seeing in the CI has now been fixed in master. If you merge from master, things should pass here. Sorry for the delay.

@aploium

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2019

@martindurant updated with master and tests passed. Thank you

@aploium

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2019

@martindurant hello, could you please merge this, thanks

@martindurant martindurant merged commit 2ed8b63 into dask:master Feb 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

DOC: add section of `Using Other S3-Compatible Services` for remote-d…
…ata-services (dask#4405)

* DOC: add section of `Using Other S3-Compatible Services` for remote-data-services

* DOC: make the doc of `Using Other S3-Compatible Services` for remote-data-services more clear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.