Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more fix #4455

Merged
merged 3 commits into from Feb 4, 2019
Merged

One more fix #4455

merged 3 commits into from Feb 4, 2019

Conversation

@inc0
Copy link

@inc0 inc0 commented Feb 2, 2019

I messed up one thing in previous PR, sorry!

  • Tests added / passed
  • Passes flake8 dask
@martindurant
Copy link
Member

@martindurant martindurant commented Feb 2, 2019

OK, so now I am confused...
Are you running any tests on these? Why are we not testing in CI?

@inc0
Copy link
Author

@inc0 inc0 commented Feb 2, 2019

I'm not sure if we run any tests - I've manually tested it yes, but it was broken before first PR too. I'll try to write tests that would catch that.

@martindurant martindurant merged commit 010f5f3 into dask:master Feb 4, 2019
2 checks passed
@martindurant martindurant mentioned this pull request Feb 5, 2019
1 task
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
* Fix bug in pyarrow and hdfs

* further fixes to pyarrow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants