Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more fix #4455

Merged
merged 3 commits into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@inc0
Copy link
Contributor

commented Feb 2, 2019

I messed up one thing in previous PR, sorry!

  • Tests added / passed
  • Passes flake8 dask

inc0 added some commits Feb 1, 2019

@martindurant

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

OK, so now I am confused...
Are you running any tests on these? Why are we not testing in CI?

@inc0

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2019

I'm not sure if we run any tests - I've manually tested it yes, but it was broken before first PR too. I'll try to write tests that would catch that.

@martindurant martindurant merged commit 010f5f3 into dask:master Feb 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@martindurant martindurant referenced this pull request Feb 5, 2019

Closed

Fix bug introduced by #4438 #4447

0 of 1 task complete

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

One more fix (dask#4455)
* Fix bug in pyarrow and hdfs

* further fixes to pyarrow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.