Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

df getitem with integer slices is not implemented #4466

Merged

Conversation

@jcrist
Copy link
Member

@jcrist jcrist commented Feb 6, 2019

Raise a NotImplementedError when calling DataFrame.getitem if the row indexer is an integer slice and the index is not a float index. Float indexes interpret integers slices as loc based, whereas all other indexers interpret them as iloc based (which is not implemented).

Fixes #4407.

Raise a `NotImplementedError` when calling DataFrame.__getitem__ *if*
the row indexer is an integer slice *and* the index is not a float
index. Float indexes interpret integers slices as `loc` based, whereas
all other indexers interpret them as `iloc` based (which is not
implemented).
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Feb 8, 2019

cc @TomAugspurger , should you find yourself with a spare moment I suspect that this would be easy for you to review.

@TomAugspurger TomAugspurger merged commit ac3fcbd into dask:master Feb 8, 2019
2 checks passed
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
Raise a `NotImplementedError` when calling DataFrame.__getitem__ *if*
the row indexer is an integer slice *and* the index is not a float
index. Float indexes interpret integers slices as `loc` based, whereas
all other indexers interpret them as `iloc` based (which is not
implemented).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants