Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cudf-specific code with dask-cudf import #4470

Merged
merged 3 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@mrocklin
Copy link
Member

commented Feb 8, 2019

I'm a little concerned about the current practice of my futzing with cudf code in the dask.dataframe codebase. I'm not yet sure how best to handle this. In the meantime here is a tiny change.

mrocklin added some commits Feb 8, 2019

Replace cudf backend code with dask_cudf import
This allows us to delegate control of the cudf backend system to dask-cudf.
This allows that project to move quickly without needing changes upstream.
It also removes cuda specific code from Dask, even if optional.

@mrocklin mrocklin changed the title Update cudf concat implementation Replace cudf-specific code with dask-cudf import Feb 8, 2019

@mrocklin

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2019

OK, I've replaced the special case code with an import to dask-cudf. That should allow that project to move more quickly while minimizing the frequency of changes necessary within this codebase.

mrocklin added a commit to mrocklin/dask-cudf that referenced this pull request Feb 8, 2019

mrocklin added a commit to rapidsai/dask-cudf that referenced this pull request Feb 8, 2019

@mrocklin

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2019

Thanks for the review @TomAugspurger

@mrocklin mrocklin merged commit 29bc263 into dask:master Feb 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mrocklin mrocklin deleted the mrocklin:cudf-concat branch Feb 8, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Replace cudf-specific code with dask-cudf import (dask#4470)
This allows us to delegate control of the cudf backend system to dask-cudf.
This allows that project to move quickly without needing changes upstream.
It also removes cuda specific code from Dask, even if optional.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.