Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix another unicode/mixed-type edge case in normalize_array #4489

merged 1 commit into from Feb 17, 2019


None yet
2 participants
Copy link

commented Feb 15, 2019

  • Tests added / passed
  • Passes flake8 dask

I initially thought that I've fixed #2713 in #4312, but I just hit an edge case that I wasn't aware of. This PR fixes that one as well and adds a regression test. Sure, the data types are weird here (bytes and unicode objects mixed), but at least dask shouldn't crash in that case.


This comment has been minimized.

Copy link

commented Feb 17, 2019

Looks good to me. Thanks for the fix @crepererum !

@mrocklin mrocklin merged commit 3d9e2ff into dask:master Feb 17, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.