Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message around set_index(inplace=True) #4501

Merged
merged 2 commits into from Feb 19, 2019

Conversation

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Feb 19, 2019

Fixes #4484

  • Tests added / passed
  • Passes flake8 dask
Copy link
Member

@jrbourbeau jrbourbeau left a comment

LGTM, thanks @mrocklin

Minor comment: adding

inplace : bool, default False
    Modifying the DataFrame in place is not supported by Dask.

to the set_index docstring could be helpful for those looking at the API documentation. I'm happy to push the docstring update to this PR if you want.

@mrocklin
Copy link
Member Author

@mrocklin mrocklin commented Feb 19, 2019

@jrbourbeau jrbourbeau merged commit 221eb09 into dask:master Feb 19, 2019
2 checks passed
@jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Feb 19, 2019

Thanks @mrocklin!

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
* Add error message around set_index(inplace=True)

Fixes dask#4484

* Add inplace to set_index docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants