Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groupby-nunique works on empty chunk #4504

Merged
merged 2 commits into from Feb 19, 2019

Conversation

@jcrist
Copy link
Member

@jcrist jcrist commented Feb 19, 2019

Previously this would error out, as groupby-apply fails to preserve
metadata on empty chunks.

Also adds a test for the other groupby reductions on empty data.

Fixes #4503.

Previously this would error out, as groupby-apply fails to preserve
metadata on empty chunks.

Also adds a test for the other groupby reductions on empty data.
@jcrist
Copy link
Member Author

@jcrist jcrist commented Feb 19, 2019

Looks like empty groupby-reductions fail for old versions of pandas (at least up to 0.20.2). I'm fine punting on this issue and just skipping that test for older pandas versions (things work fine on recent releases). Thoughts @TomAugspurger?

@TomAugspurger
Copy link
Member

@TomAugspurger TomAugspurger commented Feb 19, 2019

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Feb 19, 2019

Are you +1 on this @TomAugspurger ?

@TomAugspurger TomAugspurger merged commit 8df8e9c into dask:master Feb 19, 2019
2 checks passed
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
* groupby-nunique works on empty chunk

Previously this would error out, as groupby-apply fails to preserve
metadata on empty chunks.

Also adds a test for the other groupby reductions on empty data.

* Skip for older pandas
@tbazadaykin
Copy link

@tbazadaykin tbazadaykin commented Oct 29, 2020

Does it released already? 2.30.0 still crushed on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants