Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groupby-nunique works on empty chunk #4504

Merged
merged 2 commits into from Feb 19, 2019

Conversation

Projects
None yet
3 participants
@jcrist
Copy link
Member

commented Feb 19, 2019

Previously this would error out, as groupby-apply fails to preserve
metadata on empty chunks.

Also adds a test for the other groupby reductions on empty data.

Fixes #4503.

groupby-nunique works on empty chunk
Previously this would error out, as groupby-apply fails to preserve
metadata on empty chunks.

Also adds a test for the other groupby reductions on empty data.
@jcrist

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2019

Looks like empty groupby-reductions fail for old versions of pandas (at least up to 0.20.2). I'm fine punting on this issue and just skipping that test for older pandas versions (things work fine on recent releases). Thoughts @TomAugspurger?

@TomAugspurger

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

@mrocklin

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

Are you +1 on this @TomAugspurger ?

@TomAugspurger TomAugspurger merged commit 8df8e9c into dask:master Feb 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

groupby-nunique works on empty chunk (dask#4504)
* groupby-nunique works on empty chunk

Previously this would error out, as groupby-apply fails to preserve
metadata on empty chunks.

Also adds a test for the other groupby reductions on empty data.

* Skip for older pandas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.