Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes to pip install in dev guide #4508

merged 1 commit into from Feb 19, 2019


Copy link

@jrbourbeau jrbourbeau commented Feb 19, 2019

The current development guidelines has

pip install -e .[complete]

which works with some shells (e.g. bash) but can fail with other shells (e.g. zsh) that use square brackets for pattern matching. This PR adds quotes

pip install -e ".[complete]"

to the development guidelines to avoid this issue.

Copy link
Member Author

@jrbourbeau jrbourbeau commented Feb 19, 2019

Should have used [skip ci] instead of [skip-ci]...

Copy link

@jcrist jcrist commented Feb 19, 2019

Cancelled the builds :). Thanks @jrbourbeau, merging.

@jcrist jcrist merged commit 6c3ed46 into dask:master Feb 19, 2019
0 of 2 checks passed
@jrbourbeau jrbourbeau deleted the update-contributing branch Feb 19, 2019
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants