Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use generalized form of index checking (is_index_like) #4531

Merged
merged 1 commit into from Feb 27, 2019

Conversation

Projects
None yet
2 participants
@quasiben
Copy link
Member

commented Feb 27, 2019

  • Tests added / passed
  • Passes flake8 dask

@mrocklin do you have an idea of what a good test might be for this change ?

@mrocklin

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

Unfortunately we don't have a good lightweight pandas-like project lying around. For Dask array we tend to use sparse.

For recent cudf compatibility PRs like this I haven't been testing much in the dask/dask codebase. I think we're ok to merge this for now. We should probably start thinking about a longer term solution though.

@mrocklin

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

Merging this shortly if there are no comments.

@mrocklin

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@quasiben you might consider adding a test to dask-cudf

@quasiben

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2019

PR #4531

@mrocklin mrocklin merged commit 213f360 into dask:master Feb 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mrocklin

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.