Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct dtype when test concatenation. #4539

Merged
merged 1 commit into from Mar 6, 2019

Conversation

@QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Mar 3, 2019

When all dtypes are the same, dask returns the same dtype. When they are not all the same, then it defers to np.promote_dtypes. This function always returns native byteorder, so fix the test.

Fixes #3811.

  • Tests added / passed
  • Passes flake8 dask
When all dtypes are the same, dask returns the same dtype. When they are
not all the same, then it defers to np.promote_dtypes. This function
always returns native byteorder, so fix the test.

Fixes dask#3811.
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Mar 5, 2019

@shoyer , my guess is that you probably understand this best. If you can take a quick look I would appreciate it. My guess is that this will take you less than 120s.

@mrocklin mrocklin merged commit 4dc5940 into dask:master Mar 6, 2019
2 checks passed
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Mar 6, 2019

Thanks for the fix @QuLogic !

Glad to be able to close out the old issue :)

@QuLogic QuLogic deleted the concatenate-dtype branch Mar 6, 2019
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
When all dtypes are the same, dask returns the same dtype. When they are
not all the same, then it defers to np.promote_dtypes. This function
always returns native byteorder, so fix the test.

Fixes dask#3811.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants