Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: caching broken due to changed callback. #4542

Merged
merged 2 commits into from Mar 5, 2019

Conversation

Projects
None yet
5 participants
@rainwoodman
Copy link
Contributor

commented Mar 4, 2019

This PR implements

#4460 (comment)

It's an alternative take to #4460.

  • Tests added / passed
  • Passes flake8 dask
@mrocklin

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

cc @crepererum @jcrist for review

@jcrist

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

LGTM, provided tests pass.

Show resolved Hide resolved dask/local.py Outdated
@crepererum

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

@rainwoodman could you please add a regression test? Apart from that, thanks, good catch! 👍

@rainwoodman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

A new regression test is a bit hard. I couldn't find a minimal reliable reproducer.

It only fails when I run our entire test suite. It does not fail if I run the failed test just by itself.

On the other hand your previous regression test is still included.

@mrocklin mrocklin merged commit 6c0d96a into dask:master Mar 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.