Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: caching broken due to changed callback. #4542

Merged
merged 2 commits into from Mar 5, 2019
Merged

Conversation

@rainwoodman
Copy link
Contributor

@rainwoodman rainwoodman commented Mar 4, 2019

This PR implements

#4460 (comment)

It's an alternative take to #4460.

  • Tests added / passed
  • Passes flake8 dask
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Mar 4, 2019

cc @crepererum @jcrist for review

@jcrist
Copy link
Member

@jcrist jcrist commented Mar 4, 2019

LGTM, provided tests pass.

dask/local.py Outdated Show resolved Hide resolved
@crepererum
Copy link
Contributor

@crepererum crepererum commented Mar 5, 2019

@rainwoodman could you please add a regression test? Apart from that, thanks, good catch! 👍

@rainwoodman
Copy link
Contributor Author

@rainwoodman rainwoodman commented Mar 5, 2019

A new regression test is a bit hard. I couldn't find a minimal reliable reproducer.

It only fails when I run our entire test suite. It does not fail if I run the failed test just by itself.

On the other hand your previous regression test is still included.

@mrocklin mrocklin merged commit 6c0d96a into dask:master Mar 5, 2019
2 checks passed
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants