Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to control number of unique elements in timeseries #4557

Merged
merged 2 commits into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@mrocklin
Copy link
Member

commented Mar 6, 2019

This is useful when testing join algorithms, sometimes we want different
cardinalities for integer columns.

To generalize this we now allow passing keyword arguments directly to
individual column creation functions using a convention similar to that
used by scikit-learn parameters.

  • Tests added / passed
  • Passes flake8 dask
Add ability to control number of unique elements in timeseries
This is useful when testing join algorithms, sometimes we want different
cardinalities for integer columns.

To generalize this we now allow passing keyword arguments directly to
individual column creation functions using a convention similar to that
used by scikit-learn parameters.
@mrocklin

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

Merging tomorrow if there are no further comments.

@mrocklin mrocklin merged commit 832972d into dask:master Mar 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mrocklin mrocklin deleted the mrocklin:timeseries-control branch Mar 7, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Add ability to control number of unique elements in timeseries (dask#…
…4557)

This is useful when testing join algorithms, sometimes we want different
cardinalities for integer columns.

To generalize this we now allow passing keyword arguments directly to
individual column creation functions using a convention similar to that
used by scikit-learn parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.