Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CuPy tests or properly marks as xfail #4564

Merged
merged 2 commits into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@pentschev
Copy link
Member

commented Mar 8, 2019

  • Tests added / passed
  • Passes flake8 dask
@mrocklin

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Looks like a small linting error

$ if [[ $LINT == 'true' ]]; then flake8 dask; fi
dask/array/tests/test_cupy.py:43:49: E251 unexpected spaces around keyword / parameter equals
dask/array/tests/test_cupy.py:44:22: E128 continuation line under-indented for visual indent
The command "if [[ $LINT == 'true' ]]; then flake8 dask; fi" exited with 1.
@pentschev

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

Thanks for pointing it out @mrocklin. Is there a way to get GitHub notifications after builds complete, in particular the ones that fail?

@mrocklin

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Is there a way to get GitHub notifications after builds complete, in particular the ones that fail?

I think that this is all or nothing. Travis is willing to e-mail us when builds fail, but it would be for all builds, which would be a lot of e-mail.

@pentschev

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

No worries, I thought there was an option to opt-in only for PRs that you're the author or something, but that's fine. Thanks @mrocklin.

@mrocklin mrocklin merged commit 6fef1a3 into dask:master Mar 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mrocklin

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Thanks @pentschev !

@pentschev pentschev deleted the pentschev:fix-cupy-tests branch Mar 12, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.