Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs dataframe joins #4569

Merged
merged 4 commits into from Mar 12, 2019

Conversation

Projects
None yet
3 participants
@mrocklin
Copy link
Member

commented Mar 8, 2019

  • Tests added / passed
  • Passes flake8 dask
Large to Small Joins
--------------------

Many join or merge computations combine a large tqble with one small one. If

This comment has been minimized.

Copy link
@TomAugspurger

TomAugspurger Mar 8, 2019

Member

typo: "tqble"


.. code-block:: python
small.repartition(npartitions=1)

This comment has been minimized.

Copy link
@TomAugspurger

TomAugspurger Mar 8, 2019

Member

small = small.repartition(npartitions=1)?


The Pandas merge API supports the ``left_index=`` and ``right_index=`` options
to perform joins on the index. For Dask DataFrames these keyword options hold
special significance if the index has known divisions (see :doc:`dataframe

This comment has been minimized.

Copy link
@TomAugspurger

TomAugspurger Mar 8, 2019

Member

If you add a label above Partitions in dataframe-design like

.. _dataframe-design-partitions

Partitons
---------

you'll be able to reference like `:ref:`dataframe-design-partitions` I think, to link directly to the relevant section.

@jrbourbeau
Copy link
Member

left a comment

Couple of minor nitpicks, otherwise LGTM. Thank you for adding this @mrocklin, it reads well

Show resolved Hide resolved docs/source/dataframe-joins.rst Outdated
[skip ci] Apply suggestions from code review
Co-Authored-By: mrocklin <mrocklin@gmail.com>

@jrbourbeau jrbourbeau merged commit ebcc44e into dask:master Mar 12, 2019

@jrbourbeau

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

Thanks!

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Docs dataframe joins (dask#4569)
* [skip ci] Add docs for random array creation (dask#4566)

* [skip ci] Move categoricals outside of design doc

* respond to feedback

* [skip ci] Apply suggestions from code review

Co-Authored-By: mrocklin <mrocklin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.