Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check object for name/dtype attributes rather than type #4606

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
1 participant
@mrocklin
Copy link
Member

commented Mar 18, 2019

This is to help cudf, which handles things like Series.name as an
attribute rather than as a computed property. This seems reasonable
generally.

  • Tests added / passed
  • Passes flake8 dask
Check object for name/dtype attributes rather than type
This is to help cudf, which handles things like Series.name as an
attribute rather than as a computed property.  This seems reasonable
generally.

@mrocklin mrocklin merged commit 3a46103 into dask:master Mar 18, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mrocklin mrocklin deleted the mrocklin:is-dataframe-like-attributes branch Mar 18, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Check object for name/dtype attributes rather than type (dask#4606)
This is to help cudf, which handles things like Series.name as an
attribute rather than as a computed property.  This seems reasonable
generally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.