Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark some parquet tests xfail #4667

Merged
merged 3 commits into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@pentschev
Copy link
Member

commented Apr 4, 2019

Marking failing parquet tests xfail, see discussion in #4666.

cc @martindurant @mrocklin

  • Tests added / passed
  • Passes flake8 dask
@pentschev

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

Of course, there's also a new release of scikit-image that caused test_image to fail. I fixed the test to use u8, as expected now by `skimage.imsave. cc @mrocklin

@martindurant

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

Yep, good enough to get other PRs moving.

@martindurant martindurant merged commit 0780ca5 into dask:master Apr 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pentschev

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

Thanks for merging this @martindurant !

@pentschev pentschev deleted the pentschev:xfail-parquet-tests branch Apr 17, 2019

asmith26 added a commit to asmith26/dask that referenced this pull request Apr 22, 2019

Mark some parquet tests xfail (dask#4667)
* Mark some parquet tests xfail

* Mark one more parquet test xfail

* Use u8 for test_image, as expected by imageio

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Mark some parquet tests xfail (dask#4667)
* Mark some parquet tests xfail

* Mark one more parquet test xfail

* Use u8 for test_image, as expected by imageio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.