Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chunks='auto' to from_array #4704

Merged
merged 2 commits into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@mrocklin
Copy link
Member

commented Apr 16, 2019

This uses the "auto" chunking in da.from_array

It also uses a .chunks attribute on the dataset if present,
making the HDF5 and Zarr cases somewhat natural by default.

  • Tests added / passed
  • Passes flake8 dask

This was developed while writing up array best practices docs.

Add chunks='auto' to from_array
This uses the "auto" chunking in da.from_array

It also uses a ``.chunks`` attribute on the dataset if present,
making the HDF5 and Zarr cases somewhat natural by default.
@mrocklin

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

cc @shoyer @jakirkham for quick review

@shoyer

shoyer approved these changes Apr 17, 2019

Show resolved Hide resolved dask/array/core.py Outdated
Show resolved Hide resolved dask/array/core.py
@mrocklin

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

Merging this afternoon if there are no objections

@shoyer

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Yes, please go ahead and merge!

@mrocklin mrocklin merged commit 0cb1b57 into dask:master Apr 17, 2019

3 checks passed

codecov/project 91.22% (target 90%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mrocklin mrocklin deleted the mrocklin:from-array-auto-chunks branch Apr 17, 2019

asmith26 added a commit to asmith26/dask that referenced this pull request Apr 22, 2019

Add chunks='auto' to from_array (dask#4704)
This uses the "auto" chunking in da.from_array

It also uses a ``.chunks`` attribute on the dataset if present,
making the HDF5 and Zarr cases somewhat natural by default.

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Add chunks='auto' to from_array (dask#4704)
This uses the "auto" chunking in da.from_array

It also uses a ``.chunks`` attribute on the dataset if present,
making the HDF5 and Zarr cases somewhat natural by default.

Thomas-Z added a commit to Thomas-Z/dask that referenced this pull request May 17, 2019

Add chunks='auto' to from_array (dask#4704)
This uses the "auto" chunking in da.from_array

It also uses a ``.chunks`` attribute on the dataset if present,
making the HDF5 and Zarr cases somewhat natural by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.