Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chunks='auto' to from_array #4704

Merged
merged 2 commits into from Apr 17, 2019
Merged

Conversation

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Apr 16, 2019

This uses the "auto" chunking in da.from_array

It also uses a .chunks attribute on the dataset if present,
making the HDF5 and Zarr cases somewhat natural by default.

  • Tests added / passed
  • Passes flake8 dask

This was developed while writing up array best practices docs.

This uses the "auto" chunking in da.from_array

It also uses a ``.chunks`` attribute on the dataset if present,
making the HDF5 and Zarr cases somewhat natural by default.
@mrocklin
Copy link
Member Author

@mrocklin mrocklin commented Apr 16, 2019

cc @shoyer @jakirkham for quick review

shoyer
shoyer approved these changes Apr 17, 2019
dask/array/core.py Outdated Show resolved Hide resolved
dask/array/core.py Show resolved Hide resolved
@mrocklin
Copy link
Member Author

@mrocklin mrocklin commented Apr 17, 2019

Merging this afternoon if there are no objections

@shoyer
Copy link
Member

@shoyer shoyer commented Apr 17, 2019

Yes, please go ahead and merge!

@mrocklin mrocklin merged commit 0cb1b57 into dask:master Apr 17, 2019
3 checks passed
@mrocklin mrocklin deleted the from-array-auto-chunks branch Apr 17, 2019
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
This uses the "auto" chunking in da.from_array

It also uses a ``.chunks`` attribute on the dataset if present,
making the HDF5 and Zarr cases somewhat natural by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants