Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add draft of array best practices #4705
djhoese left a comment
I don't have permissions on this repository so just made some comments. Looks really good. Thanks for adding this information. I think it will be a really helpful resource.
I think I mentioned this in the other thread but may have forgotten, not using nested functions as callbacks. I'm not sure if there is a more general name for this rule but doing the following works in a threaded scheduler but not in others:
def my_processing(dask_arr): def my_block_func(chunk_arr, arg1, arg2): # complex logic return result_arr return dask_arr.map_blocks(my_block_func, 5, 6)
jakirkham left a comment
Generally looks great! Very helpful. Certainly know a few people that would benefit from having something like this as reference. Thanks for working on it @mrocklin !
Made a few minor comments inline with suggested code changes. Though should be pretty easy to go through.