Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dataframe.replace #4714

Merged
merged 2 commits into from Apr 18, 2019
Merged

Add Dataframe.replace #4714

merged 2 commits into from Apr 18, 2019

Conversation

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Apr 18, 2019

Fixes #4573

  • Tests added / passed
  • Passes flake8 dask
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Thanks @mrocklin, this looks good

Minor comment: Could you add replace to the DataFrame API docs?

@jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Apr 18, 2019

LGTM, will merge when CI finishes

@jrbourbeau jrbourbeau merged commit 6971f98 into dask:master Apr 18, 2019
3 checks passed
@jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Apr 18, 2019

Thanks @mrocklin!

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
* Add Dataframe.replace

Fixes dask#4573

* Add derived_from and API docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants