Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dataframe.replace #4714

Merged
merged 2 commits into from Apr 18, 2019

Conversation

Projects
None yet
2 participants
@mrocklin
Copy link
Member

commented Apr 18, 2019

Fixes #4573

  • Tests added / passed
  • Passes flake8 dask
@jrbourbeau
Copy link
Member

left a comment

Thanks @mrocklin, this looks good

Minor comment: Could you add replace to the DataFrame API docs?

@jrbourbeau

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

LGTM, will merge when CI finishes

@jrbourbeau jrbourbeau merged commit 6971f98 into dask:master Apr 18, 2019

3 checks passed

codecov/project 91.22% (target 90%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jrbourbeau

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Thanks @mrocklin!

asmith26 added a commit to asmith26/dask that referenced this pull request Apr 22, 2019

Add Dataframe.replace (dask#4714)
* Add Dataframe.replace

Fixes dask#4573

* Add derived_from and API docs

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Add Dataframe.replace (dask#4714)
* Add Dataframe.replace

Fixes dask#4573

* Add derived_from and API docs

Thomas-Z added a commit to Thomas-Z/dask that referenced this pull request May 17, 2019

Add Dataframe.replace (dask#4714)
* Add Dataframe.replace

Fixes dask#4573

* Add derived_from and API docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.