Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sizeof support for cupy.ndarray #4715

Merged
merged 2 commits into from Apr 18, 2019

Conversation

Projects
None yet
2 participants
@pentschev
Copy link
Member

commented Apr 18, 2019

@mrocklin we need this to properly calculate size of cupy.ndarrays to spill their memory to host/disk.

  • Tests added / passed
  • Passes flake8 dask
@mrocklin

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Looks fine to me. We should probably have a tiny test in test_sizeof.py that uses

cupy = pytest.importorskip('cupy')
@mrocklin

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

It won't ever be caught by our CI, but at least when we run Dask tests on GPU machines we'll pick up something.

@pentschev

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

Good idea, but doesn't it make more sense to do it in test_cupy.py perhaps?

@mrocklin

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

@mrocklin

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

+1

Merging on passed tests

@pentschev pentschev referenced this pull request Apr 18, 2019

Open

Device memory spill support #35

2 of 4 tasks complete

@mrocklin mrocklin merged commit a7bf545 into dask:master Apr 18, 2019

3 checks passed

codecov/project 91.2% (target 90%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

asmith26 added a commit to asmith26/dask that referenced this pull request Apr 22, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Thomas-Z added a commit to Thomas-Z/dask that referenced this pull request May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.