Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sizeof support for cupy.ndarray #4715

Merged
merged 2 commits into from Apr 18, 2019
Merged

Add sizeof support for cupy.ndarray #4715

merged 2 commits into from Apr 18, 2019

Conversation

@pentschev
Copy link
Member

@pentschev pentschev commented Apr 18, 2019

@mrocklin we need this to properly calculate size of cupy.ndarrays to spill their memory to host/disk.

  • Tests added / passed
  • Passes flake8 dask
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Apr 18, 2019

Looks fine to me. We should probably have a tiny test in test_sizeof.py that uses

cupy = pytest.importorskip('cupy')

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Apr 18, 2019

It won't ever be caught by our CI, but at least when we run Dask tests on GPU machines we'll pick up something.

@pentschev
Copy link
Member Author

@pentschev pentschev commented Apr 18, 2019

Good idea, but doesn't it make more sense to do it in test_cupy.py perhaps?

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Apr 18, 2019

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Apr 18, 2019

+1

Merging on passed tests

@mrocklin mrocklin merged commit a7bf545 into dask:master Apr 18, 2019
3 checks passed
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
@pentschev pentschev deleted the sizeof-cupy branch Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants