Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace #4717

Merged
merged 2 commits into from Apr 19, 2019

Conversation

Projects
None yet
2 participants
@horta
Copy link
Contributor

commented Apr 18, 2019

  • Tests added / passed
  • Passes flake8 dask
@mrocklin
Copy link
Member

left a comment

Thanks @horta !

I've added a couple comments about tests. Also, can I ask you to include this in docs/source/array-api.rst ?

Show resolved Hide resolved dask/array/tests/test_reductions.py Outdated
Show resolved Hide resolved dask/array/tests/test_reductions.py Outdated

@mrocklin mrocklin merged commit a2ebeac into dask:master Apr 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mrocklin

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

This is in. Thanks @horta !

asmith26 added a commit to asmith26/dask that referenced this pull request Apr 22, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Thomas-Z added a commit to Thomas-Z/dask that referenced this pull request May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.