Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace #4717

Merged
merged 2 commits into from Apr 19, 2019
Merged

Trace #4717

merged 2 commits into from Apr 19, 2019

Conversation

@horta
Copy link
Contributor

@horta horta commented Apr 18, 2019

  • Tests added / passed
  • Passes flake8 dask
Copy link
Member

@mrocklin mrocklin left a comment

Thanks @horta !

I've added a couple comments about tests. Also, can I ask you to include this in docs/source/array-api.rst ?

dask/array/tests/test_reductions.py Outdated Show resolved Hide resolved
dask/array/tests/test_reductions.py Outdated Show resolved Hide resolved
@mrocklin mrocklin merged commit a2ebeac into dask:master Apr 19, 2019
2 checks passed
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Apr 19, 2019

This is in. Thanks @horta !

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants