Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dtype= parameter to da.random.randint #4753

Merged
merged 2 commits into from Apr 30, 2019
Merged

Conversation

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Apr 30, 2019

Fixes #4579
Supercedes #4607

Also checked to see if there were any other cases of dtype being
supported with

import numpy

for func in dir(np.random):
    if 'dtype=' in (getattr(np.random, func).__doc__ or ''):
        print(func)
  • Tests added / passed
  • Passes flake8 dask
mrocklin and others added 2 commits Apr 30, 2019
Fixes dask#4579

Also checked to see if there were any other cases of dtype being
supported with

```
import numpy

for func in dir(np.random):
    if 'dtype=' in (getattr(np.random, func).__doc__ or ''):
        print(func)
```
Copy link
Member

@TomAugspurger TomAugspurger left a comment

Pushed a small update with an assertion on the dtype. LGTM

@jcrist
Copy link
Member

@jcrist jcrist commented Apr 30, 2019

LGTM.

@jcrist jcrist merged commit 099e1f2 into dask:master Apr 30, 2019
2 checks passed
@jcrist jcrist deleted the randint-dtype branch Apr 30, 2019
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
* Add dtype= parameter to da.random.randint

Fixes dask#4579

Also checked to see if there were any other cases of dtype being
supported with

```
import numpy

for func in dir(np.random):
    if 'dtype=' in (getattr(np.random, func).__doc__ or ''):
        print(func)
```

* assert dtype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants