Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove normed keyword in da.histogram #4755

Merged
merged 3 commits into from Apr 30, 2019

Conversation

Projects
None yet
2 participants
@mrocklin
Copy link
Member

commented Apr 30, 2019

Fixes #4547

  • Tests added / passed
  • Passes flake8 dask

mrocklin added some commits Apr 30, 2019

Remove normed argument to histogram
We raise an informative error message pointing the user to the correct
density= keyword
@jcrist

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

LGTM, merging.

@jcrist jcrist merged commit e309d6f into dask:master Apr 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jcrist jcrist deleted the mrocklin:dask-array-normed branch Apr 30, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Remove normed keyword in da.histogram (dask#4755)
* Stop testing normed keyword argument to da.histogram

* Remove normed argument to histogram

We raise an informative error message pointing the user to the correct
density= keyword

* add test for error message

Thomas-Z added a commit to Thomas-Z/dask that referenced this pull request May 17, 2019

Remove normed keyword in da.histogram (dask#4755)
* Stop testing normed keyword argument to da.histogram

* Remove normed argument to histogram

We raise an informative error message pointing the user to the correct
density= keyword

* add test for error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.