Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Remove pandas dependency of cummin_aggregate and cummax_aggregate #4765

Conversation

@beckernick
Copy link
Member

@beckernick beckernick commented May 1, 2019

Summary of Changes

  • This PR removes the pandas Series and DataFrame dependency of cummin_aggregate and cummax_aggregate in favor of checking for series/dataframe like-ness, allowing potential non-pandas backends like cuDF to be used.

  • Tests passed (none added)

  • Passes flake8 dask

This closes #4747

@beckernick beckernick changed the title [WIP] Remove pandas dependency of cummin_aggregate and cummax_aggregate [REVIEW] Remove pandas dependency of cummin_aggregate and cummax_aggregate May 1, 2019
@mrocklin
Copy link
Member

@mrocklin mrocklin commented May 1, 2019

Looks good to me. Merging. Thanks @beckernick

@mrocklin mrocklin merged commit cd988ab into dask:master May 1, 2019
2 checks passed
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
Instead we use is_series_like and is_dataframe_like
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants