Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for group_keys kwarg in DataFrame.groupby() #4771

Merged
merged 6 commits into from May 7, 2019

Conversation

Projects
None yet
3 participants
@bchu
Copy link
Contributor

commented May 2, 2019

  • Tests added / passed
  • Passes flake8 dask

Resolves #4592

@mrocklin

This comment has been minimized.

Copy link
Member

commented May 4, 2019

Thanks @bchu . In general this looks pretty good to me. It looks like there is a Python 2 syntax error. You can view this by clicking on the "Detail" link just to the right of the travis-ci row above.

@bchu

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

Fixed!

@jcrist

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Thanks @bchu, merging.

@jcrist jcrist merged commit ff0877d into dask:master May 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mrocklin added a commit to mrocklin/cudf that referenced this pull request May 7, 2019

Support the group_keys=True parameter in groupby method
This is for compatibility with dask dataframe after dask/dask#4771

mrocklin added a commit to mrocklin/cudf that referenced this pull request May 7, 2019

Support the group_keys=True parameter in groupby method
This is for compatibility with dask dataframe after dask/dask#4771

mrocklin added a commit to mrocklin/cudf that referenced this pull request May 7, 2019

Support the group_keys=True parameter in groupby method
This is for compatibility with dask dataframe after dask/dask#4771

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Add support for group_keys kwarg in DataFrame.groupby() (dask#4771)
* Add group keys

* Change to kwargs, add comment

* Remove not supported test

* Add test

* Python 2 compat

Thomas-Z added a commit to Thomas-Z/dask that referenced this pull request May 17, 2019

Add support for group_keys kwarg in DataFrame.groupby() (dask#4771)
* Add group keys

* Change to kwargs, add comment

* Remove not supported test

* Add test

* Python 2 compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.