Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit references to Pandas in dask.dataframe.groupby #4778

Merged
merged 2 commits into from May 8, 2019

Conversation

Projects
None yet
2 participants
@mrocklin
Copy link
Member

commented May 6, 2019

  • Tests added / passed
  • Passes flake8 dask
@jcrist
Copy link
Member

left a comment

Overall this looks good to me.

if is_dataframe_like(df):
return type(df)(result)
else:
return type(df.head(0).to_frame())(result)

This comment has been minimized.

Copy link
@jcrist

jcrist May 7, 2019

Member

What type is this catching? Could you add a comment explaining what may show up here?

This comment has been minimized.

Copy link
@mrocklin

mrocklin May 8, 2019

Author Member

Trying to convert Series-like objects into DataFrames. I've added a comment in the latest commit.

This comment has been minimized.

Copy link
@jcrist

jcrist May 8, 2019

Member

Thanks Matt.

@jcrist jcrist merged commit 70cb087 into dask:master May 8, 2019

@jcrist jcrist deleted the mrocklin:groupby-dataframe branch May 8, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Remove explicit references to Pandas in dask.dataframe.groupby (dask#…
…4778)

* Remove explicit references to Pandas in dask.dataframe.groupby

* Add comment explaining behavior [skip ci]

Thomas-Z added a commit to Thomas-Z/dask that referenced this pull request May 17, 2019

Remove explicit references to Pandas in dask.dataframe.groupby (dask#…
…4778)

* Remove explicit references to Pandas in dask.dataframe.groupby

* Add comment explaining behavior [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.