Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit references to Pandas in dask.dataframe.groupby #4778

Merged
merged 2 commits into from May 8, 2019

Conversation

@mrocklin
Copy link
Member

@mrocklin mrocklin commented May 6, 2019

  • Tests added / passed
  • Passes flake8 dask
Copy link
Member

@jcrist jcrist left a comment

Overall this looks good to me.

if is_dataframe_like(df):
return type(df)(result)
else:
return type(df.head(0).to_frame())(result)
Copy link
Member

@jcrist jcrist May 7, 2019

What type is this catching? Could you add a comment explaining what may show up here?

Copy link
Member Author

@mrocklin mrocklin May 8, 2019

Trying to convert Series-like objects into DataFrames. I've added a comment in the latest commit.

Copy link
Member

@jcrist jcrist May 8, 2019

Thanks Matt.

@jcrist jcrist merged commit 70cb087 into dask:master May 8, 2019
@jcrist jcrist deleted the groupby-dataframe branch May 8, 2019
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
…4778)

* Remove explicit references to Pandas in dask.dataframe.groupby

* Add comment explaining behavior [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants