Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core dask config file to MANIFEST.in #4780

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
2 participants
@jrbourbeau
Copy link
Member

commented May 7, 2019

Noticed CI failures in distributed (ref https://travis-ci.org/dask/distributed/jobs/529018634) that I think is related to the new dask/dask.yaml config file (added in #4774).

I suspect dask/dask.yaml should be included in MANIFEST.in and we should have include_package_data=True in setup.py. This way dask/dask.yaml will be included as a data file when dask is installed.

cc @mrocklin

@mrocklin

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Ah indeed. Thanks for catching and resolving this @jrbourbeau

@jrbourbeau jrbourbeau merged commit bd603f1 into dask:master May 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jrbourbeau jrbourbeau deleted the jrbourbeau:update-manifest branch May 7, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Thomas-Z added a commit to Thomas-Z/dask that referenced this pull request May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.