Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Generalize `hash_pandas_object` in `hash_shard` for `split_out` argument to work in non-pandas backends #5184
TomAugspurger left a comment
A couple small comments.
Can you add basic tests for that our dispatch is working correctly for pandas objects.
@pytest.mark.parametrize('obj', [pd.Index(...), pd.Series(...), pd.DataFrame(...)]) def test_hash_object_dispatch(obj): result = dd.util.hash_object_dispatch(obj) expected = pd.util.hash_pandas_object(obj) tm.assert_equal(result, expected)
@TomAugspurger, Added tests accordingly. This is ready for review.