Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add columns argument in drop function #5223

Merged
merged 3 commits into from Aug 5, 2019

Conversation

henriqueribeiro
Copy link
Contributor

@henriqueribeiro henriqueribeiro commented Aug 5, 2019

  • Tests added / passed
  • Passes black dask / flake8 dask

Solves #5216

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Thanks for working on this @henriqueribeiro, generally the changes here look good!

Could you update the NotImplementedError message to include columns. Perhaps something like "Drop currently only works for axis=1 or when columns is not None".

Looks like black is taking issue with one file (ref https://travis-ci.org/dask/dask/jobs/567840498#L1412). Running black dask locally will fix the CI issues. Also, while not required, you may consider setting up pre-commit hooks to automatically run flake8 and black in the future.

@henriqueribeiro
Copy link
Contributor Author

@henriqueribeiro henriqueribeiro commented Aug 5, 2019

Done! 👍

@jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Aug 5, 2019

Thanks @henriqueribeiro, this is in!

(note the AppVeyor tests are unrelated to the changes in this PR)

@jrbourbeau jrbourbeau merged commit 8cf8742 into dask:master Aug 5, 2019
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants