Put conda-forge over defaults in windows tests #5228
Conversation
Our windows tests are currently failing, likely due to a difference in environment (numba 0.45.0 is being used from defaults in appveyor, numba 0.45.1 is being used from conda-forge on travis). We update our environment.yml to specify using conda-forge over defaults when possible.
|
Hmmm, this may also be due to pydata/sparse#257. Will wait for appveyor before looking further. |
| @@ -1,10 +1,11 @@ | |||
| name: testenv | |||
| channels: | |||
| - conda-forge | |||
| - defaults | |||
There was a problem hiding this comment.
Do we need the default channel, or does conda-forge still suffice?
There was a problem hiding this comment.
This looks correct to me. Dropping it would mean we don't use defaults at all, which is probably not what we want.
There was a problem hiding this comment.
Is there a reason to use defaults if all the packages we want to install are in conda-forge?
There was a problem hiding this comment.
Dropping it would mean we don't use defaults at all, which is probably not what we want.
Actually, IIUC this change was worthless except for explicitly orderining conda-forge and defaults - we'd have to add nodefaults to the channel list to disable defaults entirely (otherwise its implicitly there): https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html
The real fix here was to pin numpy, but I'm reluctant to make another commit since this PR works as is and this change is harmless.
There was a problem hiding this comment.
If so, we may consider adding defaults to our other CI environments (doesn't have to be in this PR)
There was a problem hiding this comment.
I'm reluctant to make another commit since this PR works as is and this change is harmless
Totally fine by me. I was just curious if I was missing something about how specifying channels works with conda
|
Some minor comments. Otherwise LGTM. |
Co-Authored-By: jakirkham <jakirkham@gmail.com>
Our windows tests are currently failing, likely due to a difference in
environment (numba 0.45.0 is being used from defaults in appveyor, numba
0.45.1 is being used from conda-forge on travis). We update our
environment.yml to specify using conda-forge over defaults when
possible.