Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make boxes for dask-spark page #5249

Merged
merged 6 commits into from Aug 8, 2019

Conversation

@martindurant
Copy link
Member

commented Aug 7, 2019

@martindurant

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

Looks like:

Screen Shot 2019-08-07 at 14 25 34

The remaining parts of the previous page is nested by API, so would need at least better headings.

@mrocklin mrocklin referenced this pull request Aug 7, 2019
18 of 29 tasks complete
@jrbourbeau

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

@martindurant your proposal of replacing the nested structure with "DataFrame API", "Array API", etc. seems like a good way forward

@martindurant martindurant changed the title WIP: Make boxes for dask-spark page Make boxes for dask-spark page Aug 7, 2019

docs/source/spark.rst Outdated Show resolved Hide resolved
Update docs/source/spark.rst
Co-Authored-By: Tom Augspurger <TomAugspurger@users.noreply.github.com>
@mrocklin

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

@TomAugspurger @jrbourbeau you both think a bit about style from time to time. Any thoughts on things that we can do to improve styling or layout here? This is one of our most viewed pages, so making it look nice is probably worth some effort.

@jrbourbeau

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

As it stands now, I think the "Dask" and "Spark" table column titles stand out more than the "Language", "Ecosystem", etc. category text. We might consider making the "Dask" and "Spark" titles italicized, instead of bold, and make "Language", etc. smaller section titles. E.g.

Language:

becomes

Language
^^^^^^^^

Which would look like

Screen Shot 2019-08-08 at 10 51 13 AM

I'm curious what others think

docs/source/spark.rst Outdated Show resolved Hide resolved
Update docs/source/spark.rst
Co-Authored-By: James Bourbeau <jrbourbeau@users.noreply.github.com>
@TomAugspurger

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Looks good. I think a vertical-align: top for the table cells might look a bit nicer.

@martindurant

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

Note: I cannot figure out how to push the text in the boxes to the top

@TomAugspurger

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Hmm that's a bit unfortunate. Not worth worrying about though.

@jrbourbeau jrbourbeau merged commit 6f38240 into dask:master Aug 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@martindurant martindurant deleted the martindurant:spark_doc_boxes branch Aug 8, 2019

@jrbourbeau

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Thanks @martindurant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.