Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale label github action

Merged
merged 3 commits into from Oct 19, 2021
Merged

Stale label github action #8244

merged 3 commits into from Oct 19, 2021

Conversation

GenevieveBuckley
Copy link
Contributor

@GenevieveBuckley GenevieveBuckley commented Oct 11, 2021

As discussed here we want a bot to automatically label stale issues in the repository, in the least obnoxious way possible.

This PR introduces a yml file for the github actions/stale, to run automatically on a regular interval.

days-before-close: -1
stale-issue-label: 'needs attention'
stale-pr-label: 'needs attention'
exempt-issue-labels: 'good intro to dask,good first issue,Good First Issue,good second issue,feature request'
Copy link
Contributor Author

@GenevieveBuckley GenevieveBuckley Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list of labels could be tidied up a bit.

  • Discussed previously, "good first issue" is going to get changed to "good intro to dask" but this hasn't happened just yet (I can't do it - to edit labels you need write permissions to a repository & I only have triage team permissions here)
  • The "good first issue" label in dask/dask is all lowercase, but over in distributed it's "Good First Issue" (title case). I figure people are reasonably likely to copy-paste yaml files to other repos, so it seems easier to just have extra redundancy here even if it could be more succinct.

stale-issue-label: 'needs attention'
stale-pr-label: 'needs attention'
exempt-issue-labels: 'good intro to dask,good first issue,Good First Issue,good second issue,feature request'
exempt-pr-labels: 'awaiting-approval,work-in-progress'
Copy link
Contributor Author

@GenevieveBuckley GenevieveBuckley Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually seem to use labels like these in either dask or dask/distributed. I could take them out, or like above I could leave them in just so it's clearer how to use the yaml file.

Copy link
Member

@jsignell jsignell Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should take them out or comment them out.

Copy link
Contributor Author

@GenevieveBuckley GenevieveBuckley Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll comment it out then. That's a bit easier than making someone dig around in the documentation later on if they want to just change something quickly.

@jsignell
Copy link
Member

jsignell commented Oct 18, 2021

I'm wondering if this should actually go in https://github.com/dask/.github and then all of the repos can reference it from there.

@jrbourbeau
Copy link
Member

jrbourbeau commented Oct 18, 2021

Would that cause things to be marked as stale across all projects in the Dask org? Maybe we should experiment here and in distributed first before apply to all repos

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Just checking in, is there anything else we'd like to do here, or is this ready to try out?

.github/workflows/stale-bot.yaml Outdated Show resolved Hide resolved
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
@jsignell
Copy link
Member

jsignell commented Oct 19, 2021

👍 from me

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Alright, let's give this try then. I just created a needs attention label, so this should be good to go. Thanks @GenevieveBuckley!

@jrbourbeau jrbourbeau merged commit 98fed9b into dask:main Oct 19, 2021
27 checks passed
@GenevieveBuckley GenevieveBuckley deleted the stalebot branch Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants