Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tmpdir and tmpfile context manager docstrings #8270

Conversation

mesejo
Copy link
Contributor

@mesejo mesejo commented Oct 17, 2021

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Thanks for putting this together @mesejo! I left a few small suggestions, but overall this looks good

dask/utils.py Outdated Show resolved Hide resolved
dask/utils.py Outdated Show resolved Hide resolved
dask/utils.py Outdated Show resolved Hide resolved
dask/utils.py Outdated Show resolved Hide resolved
dask/utils.py Outdated Show resolved Hide resolved
dask/utils.py Outdated Show resolved Hide resolved
mesejo and others added 6 commits Oct 20, 2021
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
@mesejo mesejo force-pushed the update-tmpdir-and-tmpfile-context-manager-docstrings branch from 9d4406a to dcc79a0 Compare Oct 20, 2021
@mesejo
Copy link
Contributor Author

mesejo commented Oct 20, 2021

@jrbourbeau Thanks for reviewing! I agree with your suggestions and believe now it looks better.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Thanks @mesejo. This looks great -- will merge after CI finishes

@jrbourbeau jrbourbeau changed the title Update tmpdir and tmpfile context manager docstrings (#7800) Update tmpdir and tmpfile context manager docstrings Oct 20, 2021
@jrbourbeau jrbourbeau merged commit f424669 into dask:main Oct 20, 2021
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants