Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister callbacks in doctests

Merged
merged 1 commit into from Oct 20, 2021
Merged

Conversation

jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Oct 19, 2021

Some of our callback doctests weren't calling unregister() which lead to Callback.active being unexpectedly populated when running both unit tests and doctests at the same time. This PR adds unregister() calls accordingly.

cc @GenevieveBuckley

Closes #8268

@GenevieveBuckley
Copy link
Contributor

GenevieveBuckley commented Oct 19, 2021

Thanks James! I'll try this out now

@GenevieveBuckley
Copy link
Contributor

GenevieveBuckley commented Oct 19, 2021

Yes, can confirm this PR fixes #8268

Thanks James! Nice detective work 😄

Copy link
Member

@jsignell jsignell left a comment

beautiful!

@jsignell jsignell merged commit 5b63301 into dask:main Oct 20, 2021
27 checks passed
@jrbourbeau jrbourbeau deleted the callback-updates branch Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants