Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chest

Merged
merged 1 commit into from Oct 21, 2021
Merged

Remove chest #8279

merged 1 commit into from Oct 21, 2021

Conversation

jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Oct 20, 2021

This PR removes several references to the chest package which are outdated and no longer used today

xref #8278

cc @jsignell

try:
from chest import Chest as Cache
except ImportError:
Cache = dict

Copy link
Member Author

@jrbourbeau jrbourbeau Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cache isn't used anymore

if DEBUG:
from chest.core import nbytes

print(
"Key: %s\tDep: %s\t NBytes: %.2f\t Release"
% (key, dep, sum(map(nbytes, state["cache"].values()) / 1e6))
)
Copy link
Member Author

@jrbourbeau jrbourbeau Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this DEBUG flag being used anywhere else. It was probably useful at one point, but I'm fine removing this conditional print

Copy link
Member

@jsignell jsignell left a comment

Woohoo!!

@jrbourbeau
Copy link
Member Author

jrbourbeau commented Oct 21, 2021

Thanks for reviewing @jsignell

@jrbourbeau jrbourbeau merged commit a544670 into dask:main Oct 21, 2021
27 checks passed
@jrbourbeau jrbourbeau deleted the remove-chest branch Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants