From 9b1e8936a177ef5c3153f1b4a4431b4367affb70 Mon Sep 17 00:00:00 2001 From: Pavithra Eswaramoorthy Date: Tue, 2 Aug 2022 01:53:46 +0530 Subject: [PATCH 1/3] xfail test_solve_sym_pos --- dask/array/tests/test_linalg.py | 1 + 1 file changed, 1 insertion(+) diff --git a/dask/array/tests/test_linalg.py b/dask/array/tests/test_linalg.py index b9fb33ecce9..4236feac4b5 100644 --- a/dask/array/tests/test_linalg.py +++ b/dask/array/tests/test_linalg.py @@ -760,6 +760,7 @@ def _get_symmat(size): return lA.dot(lA.T) +@pytest.mark.xfail(reason="https://github.com/dask/dask/issues/9335", strict=False) @pytest.mark.parametrize(("shape", "chunk"), [(20, 10), (30, 6)]) def test_solve_sym_pos(shape, chunk): np.random.seed(1) From a3f258cd2466183ecfc67e73bf63bf013a5c9d3c Mon Sep 17 00:00:00 2001 From: Pavithra Eswaramoorthy Date: Tue, 2 Aug 2022 02:28:34 +0530 Subject: [PATCH 2/3] xfail only if scipy >= 1.9.0 --- dask/array/tests/test_linalg.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dask/array/tests/test_linalg.py b/dask/array/tests/test_linalg.py index 4236feac4b5..043da2bbf21 100644 --- a/dask/array/tests/test_linalg.py +++ b/dask/array/tests/test_linalg.py @@ -760,7 +760,11 @@ def _get_symmat(size): return lA.dot(lA.T) -@pytest.mark.xfail(reason="https://github.com/dask/dask/issues/9335", strict=False) +@pytest.mark.xfail( + scipy.__version__ >= "1.9.0", + reason="https://github.com/dask/dask/issues/9335", + strict=False, +) @pytest.mark.parametrize(("shape", "chunk"), [(20, 10), (30, 6)]) def test_solve_sym_pos(shape, chunk): np.random.seed(1) From 15c97cf00815a9d113e6372f86df15a8791db0c5 Mon Sep 17 00:00:00 2001 From: James Bourbeau Date: Mon, 1 Aug 2022 18:45:15 -0500 Subject: [PATCH 3/3] Parse version strings --- dask/array/tests/test_linalg.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dask/array/tests/test_linalg.py b/dask/array/tests/test_linalg.py index 043da2bbf21..1ad6c938f84 100644 --- a/dask/array/tests/test_linalg.py +++ b/dask/array/tests/test_linalg.py @@ -761,9 +761,8 @@ def _get_symmat(size): @pytest.mark.xfail( - scipy.__version__ >= "1.9.0", + parse_version(scipy.__version__) >= parse_version("1.9.0"), reason="https://github.com/dask/dask/issues/9335", - strict=False, ) @pytest.mark.parametrize(("shape", "chunk"), [(20, 10), (30, 6)]) def test_solve_sym_pos(shape, chunk):