New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RemovedIn20Warning
filtering
#9814
Open
jrbourbeau
wants to merge
2
commits into
dask:main
Choose a base branch
from
jrbourbeau:filter-sqlalchemy-warning
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
approved these changes
Jan 9, 2023
graingert
reviewed
Jan 11, 2023
@@ -738,6 +738,7 @@ async def test_pack_MaterializedLayer_handles_futures_in_graph_properly(c, s, a, | |||
assert unpacked["deps"] == {"x": {fut.key}, "y": {fut.key}, "z": {"y"}} | |||
|
|||
|
|||
@pytest.mark.filterwarnings("ignore:.*:dask.tests.warning_aliases.RemovedIn20Warning") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is protected by pytest.importorskip("sqlalchemy")
and so should just work with:
Suggested change
@pytest.mark.filterwarnings("ignore:.*:dask.tests.warning_aliases.RemovedIn20Warning") | |
@pytest.mark.filterwarnings("ignore:.*:sqlalchemy.ext.RemovedIn20Warning") |
graingert
reviewed
Jan 11, 2023
@@ -41,6 +41,7 @@ def db(): | |||
yield uri | |||
|
|||
|
|||
@pytest.mark.filterwarnings("ignore:.*:dask.tests.warning_aliases.RemovedIn20Warning") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
@pytest.mark.filterwarnings("ignore:.*:dask.tests.warning_aliases.RemovedIn20Warning") | |
@pytest.mark.filterwarnings("ignore:.*:sqlalchemy.ext.RemovedIn20Warning") |
github-actions
bot
added
the
needs attention
It's been a while since this was pushed on. Needs attention from the owner or a maintainer.
label
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dataframe
io
needs attention
It's been a while since this was pushed on. Needs attention from the owner or a maintainer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #9809 (review)
cc @charlesbluca @graingert