Respect timeouts when restarting #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously restarting a cluster that had long-running tasks would sometimes
hang. This was because of two reasons:
1. The nanny's restart timeout was longer than the scheduler's restart
timeout
Now we pass a fraction of the scheduler's timeout down to the nanny
2. The workers used to wait for the executor to finish all currently
running tasks.
Now we don't
Fixes dask#1303
3.2 is raising SkipErrors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously restarting a cluster that had long-running tasks would sometimes
hang. This was because of two reasons:
The nanny's restart timeout was longer than the scheduler's restart
timeout
Now we pass a fraction of the scheduler's timeout down to the nanny
The workers used to wait for the executor to finish all currently
running tasks.
Now we don't
Fixes #1303 . Either of these changes are enough to fix the issue independently.
@eferreira