Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cudf serialization/deserialization #2881

Merged
merged 13 commits into from Aug 18, 2019

Conversation

@quasiben
Copy link
Member

commented Jul 24, 2019

This in conjunction with:

Will fix: #2830

I would not merge this until rapidsai/cudf#2378 is merged in

@mrocklin
Copy link
Member

left a comment

A couple small comments, but in general this looks good to me. Thanks @quasiben for cleaning this up

distributed/__init__.py Outdated Show resolved Hide resolved
distributed/protocol/cudf.py Outdated Show resolved Hide resolved
@quasiben

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

@mrocklin I think this is ready to be merged in. There are still issues with running a distributed join with cudf+ucx+dask. Folks are investigating ucx-py and cudf and I think it best to get everyone on "master"

@mrocklin

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

OK, there is a dask release happening later today. Should this go in as part of that release (is it critical?) or can we merge it after the release occurs? I have a preference for afterwards, just so that it gets a bit more use by bleeding edge users before it goes into a proper release.

@quasiben

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

Afterwards makes sense. Thanks!

@mrocklin mrocklin merged commit 2bff61d into dask:master Aug 18, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.