Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts to processes in SSH tests #2925

Merged
merged 1 commit into from Aug 4, 2019

Conversation

@mrocklin
Copy link
Member

commented Aug 4, 2019

It turns out that OpenSSH doesn't pass through terminate/kill signals,
so we had some zombie processes hanging around sending signals around where
they shouldn't.

Now we place idle and death timeouts on the launched processes to keep them in
check.

See ronf/asyncssh#112 for more information on the
underlying issue.

Add timeouts to processes in SSH tests
It turns out that OpenSSH doesn't pass through terminate/kill signals,
so we had some zombie processes hanging around sending signals around where
they shouldn't.

Now we place idle and death timeouts on the launched processes to keep them in
check.

See ronf/asyncssh#112 for more information on the
underlying issue.

@mrocklin mrocklin merged commit 2938970 into dask:master Aug 4, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@mrocklin mrocklin deleted the mrocklin:ssh2-tests-death-timeou branch Aug 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.