Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINT: Fixup black string normalization #2929

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@jcrist
Copy link
Member

commented Aug 6, 2019

After running black, several places in our codebase were rewritten from
something like

raise ValueError("part one of the message "
                 "part two")

to

raise ValueError("part one of the message " "part two")

This fixes those cases, removing the unnecessary two-part string.

Stumbled across this when doing some other work, and it was a
quick fix. See also dask/dask#5227.

LINT: Fixup black string normalization
After running black, several places in our codebase were rewritten from
something like

```
raise ValueError("part one of the message "
                 "part two")
```

to

```
raise ValueError("part one of the message " "part two")
```

This fixes those cases, removing the unnecessary two-part string.
@@ -139,7 +139,7 @@ def main(
tls_cert,
tls_key,
dashboard_address,
**kwargs
**kwargs,

This comment has been minimized.

Copy link
@mrocklin

mrocklin Aug 6, 2019

Member

This excludes Python 3.5 . You'll have to update your black to master, or the commit in the pre-commit config file. :/

This comment has been minimized.

Copy link
@jcrist

jcrist Aug 6, 2019

Author Member

Ah, didn't realize this required a non-released version of black.

This comment has been minimized.

Copy link
@jcrist

jcrist Aug 6, 2019

Author Member

Found the lines that were confusing black and fixed them, should now work fine with the latest black release or master.

jcrist added 2 commits Aug 6, 2019
Linting no longer requires non-released black
Removing trailing commas after kwargs in function calls

@mrocklin mrocklin merged commit cf10db7 into dask:master Aug 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mrocklin

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Thanks @jcrist !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.