Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINT: Fixup black string normalization #2929

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@jcrist
Copy link
Member

@jcrist jcrist commented Aug 6, 2019

After running black, several places in our codebase were rewritten from
something like

raise ValueError("part one of the message "
                 "part two")

to

raise ValueError("part one of the message " "part two")

This fixes those cases, removing the unnecessary two-part string.

Stumbled across this when doing some other work, and it was a
quick fix. See also dask/dask#5227.

After running black, several places in our codebase were rewritten from
something like

```
raise ValueError("part one of the message "
                 "part two")
```

to

```
raise ValueError("part one of the message " "part two")
```

This fixes those cases, removing the unnecessary two-part string.
@@ -139,7 +139,7 @@ def main(
tls_cert,
tls_key,
dashboard_address,
**kwargs
**kwargs,
Copy link
Member

@mrocklin mrocklin Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This excludes Python 3.5 . You'll have to update your black to master, or the commit in the pre-commit config file. :/

Loading

Copy link
Member Author

@jcrist jcrist Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't realize this required a non-released version of black.

Loading

Copy link
Member Author

@jcrist jcrist Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the lines that were confusing black and fixed them, should now work fine with the latest black release or master.

Loading

jcrist added 2 commits Aug 6, 2019
Removing trailing commas after kwargs in function calls
@mrocklin mrocklin merged commit cf10db7 into dask:master Aug 6, 2019
2 checks passed
Loading
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Aug 6, 2019

Thanks @jcrist !

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants