Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap offload in gen.coroutine #2934

Merged
merged 2 commits into from Aug 7, 2019

Conversation

@mrocklin
Copy link
Member

commented Aug 6, 2019

Previously we would return the bare concurrent.future.Future
which was not awaitable. Now we rely on Tornado's gen.coroutine
logic to handle this.

Fixes #2928

Wrap offload in gen.coroutine
Previously we would return the bare concurrent.future.Future
which was not awaitable.  Now we rely on Tornado's gen.coroutine
logic to handle this.

Fixes #2928

@mrocklin mrocklin merged commit 8d7e166 into dask:master Aug 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mrocklin mrocklin deleted the mrocklin:offload-coroutine branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.