Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap offload in gen.coroutine #2934

Merged
merged 2 commits into from Aug 7, 2019
Merged

Wrap offload in gen.coroutine #2934

merged 2 commits into from Aug 7, 2019

Conversation

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Aug 6, 2019

Previously we would return the bare concurrent.future.Future
which was not awaitable. Now we rely on Tornado's gen.coroutine
logic to handle this.

Fixes #2928

Previously we would return the bare concurrent.future.Future
which was not awaitable.  Now we rely on Tornado's gen.coroutine
logic to handle this.

Fixes dask#2928
@mrocklin mrocklin merged commit 8d7e166 into dask:master Aug 7, 2019
2 checks passed
Loading
@mrocklin mrocklin deleted the offload-coroutine branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant