Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from collections.abc #2938

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@jcrist
Copy link
Member

commented Aug 7, 2019

Silences deprecation warnings about importing from collections instead of collections.abc.

Import from collections.abc
Silences deprecation warnings about importing from collections instead
of collections.abc.
@jcrist

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

I looked at adding a test for this, but couldn't get pytest's filterwarnings to catch this. I think it's because they're warnings on import, and pytest's warning filtering only comes into affect during tests (where the warning will have already occurred).

@mrocklin

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

+1 if CI passes

@jcrist jcrist merged commit 4d98bb5 into dask:master Aug 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jcrist jcrist deleted the jcrist:collections-abc branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.