Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cores= and memory= keywords to scale #2974

Merged
merged 3 commits into from Aug 22, 2019
Merged

Conversation

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Aug 21, 2019

Dask-Jobqueue did this internally.
It seems like a decent idea to pull upstream.

Dask-Jobqueue did this internally.
It seems like a decent idea to pull upstream.
@mrocklin
Copy link
Member Author

@mrocklin mrocklin commented Aug 21, 2019

cc @guillaumeeb for review (I think that you did this originally?)

Loading

distributed/deploy/spec.py Outdated Show resolved Hide resolved
Loading
Copy link
Member

@guillaumeeb guillaumeeb left a comment

Thanks for this!
This looks good to me, but I just tried to get familiar with SpecCluster...

Loading

@mrocklin mrocklin merged commit 799b5a0 into dask:master Aug 22, 2019
2 checks passed
Loading
@mrocklin mrocklin deleted the scale-cores-memory branch Aug 22, 2019
@guillaumeeb
Copy link
Member

@guillaumeeb guillaumeeb commented Aug 22, 2019

Currently testing Dask-jobqueue SpecCluster PR. This does not work because dask-jobqueue uses the custom Job class, which does not need memory or nthreads argument, or at least not in every implementations. For PBS, cluster.new_spec looks like this :

{'cls': dask_jobqueue.pbs.PBSJob,
 'options': {'cores': 4,
  'memory': '20Gb',
  'walltime': '01:00:00',
  'interface': None,
  'protocol': 'tcp://',
  'security': None}}

Should we modify this in dask-jobqueue's side?

We also lack the nice widget for filling cores or memory in jupyter, see #2985

Loading

@mrocklin
Copy link
Member Author

@mrocklin mrocklin commented Aug 30, 2019

I believe I have resolved this latest comment. We now check for a variety of terms, like cores, threads, nthreads, and so on

Loading

@mrocklin
Copy link
Member Author

@mrocklin mrocklin commented Aug 30, 2019

Although the widget issue is still live. Thank you for raising an issue.

Loading

@guillaumeeb
Copy link
Member

@guillaumeeb guillaumeeb commented Aug 30, 2019

Will try to test again all this next week, but not sure I can find the time.

Thanks a lot for all the work!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants