Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly import progress from diagnostics.progressbar #2975

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@mrocklin
Copy link
Member

commented Aug 21, 2019

For some reason the implicit import behavior has changed.

Fixes #2973

Directly import progress from diagnostics.progressbar
For some reason the implicit import behavior has changed.

Fixes #2973
@jrbourbeau

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

FWIW, I tracked down a55515569d4c5da734e5b14ae414cd342c37ed7b as the commit where this import behavior changed. It wasn't immediately clear how the changes in #2932 caused the import behavior to change, and I'm not sure how much value there is in tracking it down.

The changes here make the import more explicit, which I'm generally in favor of

@mrocklin mrocklin merged commit 6e0fecf into dask:master Aug 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mrocklin mrocklin deleted the mrocklin:explicit-progress-import branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.