Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RST syntax and tree fixes #2981

Merged
merged 3 commits into from Aug 21, 2019

Conversation

@rs2
Copy link
Contributor

commented Aug 21, 2019

Remaining Sphinx warnings:

WARNING: error while formatting arguments for distributed.diagnostics.progress: module 'distributed.diagnostics.progress' has no attribute '__mro__'
WARNING: html_static_path entry '~/code/distributed/docs/source/_static' does not exist
@mrocklin
Copy link
Member

left a comment

Thanks for doing this! I have a couple of small comments about the ec2 file (which we should probably remove) but otherwise this looks great!

@@ -1 +1,4 @@
Cloud Deployment
=================

See `Dask's cloud deployment documentation <https://dask.pydata.org/en/latest/setup/cloud.html>`_ for up-to-date documentation for deployment on Amazon's Cloud.

This comment has been minimized.

Copy link
@mrocklin

mrocklin Aug 21, 2019

Member

We no longer publish this file. It's only here in order to redirect users.

Probably we should just use a proper redirect. There is a dictionary of redirects in source/conf.py that might be good for this.

docs/source/index.rst Outdated Show resolved Hide resolved
@@ -239,7 +239,7 @@ Nanny
Dask workers are by default launched, monitored, and managed by a small Nanny
process.

.. autoclass:: distributed.worker.Nanny
.. autoclass:: distributed.nanny.Nanny

This comment has been minimized.

Copy link
@mrocklin

mrocklin Aug 21, 2019

Member

Whoops. Thanks!

rs2 and others added 2 commits Aug 21, 2019
Review comments
Co-Authored-By: Matthew Rocklin <mrocklin@gmail.com>
@rs2

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

@mrocklin Thank you, over to you.

@mrocklin mrocklin merged commit 88fd0d2 into dask:master Aug 21, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mrocklin

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Thanks @rs2 ! Merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.