Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RST syntax and tree fixes #2981

Merged
merged 3 commits into from Aug 21, 2019
Merged

RST syntax and tree fixes #2981

merged 3 commits into from Aug 21, 2019

Conversation

@rs2
Copy link
Contributor

@rs2 rs2 commented Aug 21, 2019

Remaining Sphinx warnings:

WARNING: error while formatting arguments for distributed.diagnostics.progress: module 'distributed.diagnostics.progress' has no attribute '__mro__'
WARNING: html_static_path entry '~/code/distributed/docs/source/_static' does not exist
Copy link
Member

@mrocklin mrocklin left a comment

Thanks for doing this! I have a couple of small comments about the ec2 file (which we should probably remove) but otherwise this looks great!

Loading

@@ -1 +1,4 @@
Cloud Deployment
=================

See `Dask's cloud deployment documentation <https://dask.pydata.org/en/latest/setup/cloud.html>`_ for up-to-date documentation for deployment on Amazon's Cloud.
Copy link
Member

@mrocklin mrocklin Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer publish this file. It's only here in order to redirect users.

Probably we should just use a proper redirect. There is a dictionary of redirects in source/conf.py that might be good for this.

Loading

docs/source/index.rst Outdated Show resolved Hide resolved
Loading
@@ -239,7 +239,7 @@ Nanny
Dask workers are by default launched, monitored, and managed by a small Nanny
process.

.. autoclass:: distributed.worker.Nanny
.. autoclass:: distributed.nanny.Nanny
Copy link
Member

@mrocklin mrocklin Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Thanks!

Loading

rs2 and others added 2 commits Aug 21, 2019
Co-Authored-By: Matthew Rocklin <mrocklin@gmail.com>
@rs2
Copy link
Contributor Author

@rs2 rs2 commented Aug 21, 2019

@mrocklin Thank you, over to you.

Loading

@mrocklin mrocklin merged commit 88fd0d2 into dask:master Aug 21, 2019
1 of 2 checks passed
Loading
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Aug 21, 2019

Thanks @rs2 ! Merged in.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants