Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip exceptions in startup information #2991

Merged
merged 2 commits into from Aug 23, 2019

Conversation

@jacobtomlinson
Copy link
Member

commented Aug 23, 2019

Turns out #2984 doesn't completely solve rapidsai/dask-cuda#122. Not sure why my local testing was working yesterday as today it doesn't.

We also need to skip exceptions when gathering startup information as that may also use pynvml.

@mrocklin

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Thanks for this, can I ask for a tiny test, similar to this

@pytest.mark.asyncio
async def test_bad_metrics(cleanup):
def bad_metric(w):
raise Exception("Hello")
async with Scheduler() as s:
async with Worker(s.address, metrics={"bad": bad_metric}) as w:
assert "bad" not in s.workers[w.address].metrics

You should be able to provide a startup_information=[bad_function] keyword to the worker.

I can also handle this is you're out

@jacobtomlinson

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2019

Added :)

@mrocklin mrocklin merged commit d3b075e into dask:master Aug 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.